lambdaisland / kaocha

Full featured next gen Clojure test runner
https://cljdoc.org/d/lambdaisland/kaocha/1.0.861/doc/1-introduction
Eclipse Public License 1.0
792 stars 81 forks source link

332 plugin kaocha plugin profiling does not run when watch is used #393

Closed fdserr closed 1 year ago

fdserr commented 1 year ago

Wrap the callsite to api/run in the watcher with the post-summary hook, exactly as in the runner.

plexus commented 1 year ago

This looks good, but it changes some of the watch output, so some of the tests need updating. And it has conflicts with main at this point. @alysbrooks do you think you can wrap this up? I don't think we can still count on François.

alysbrooks commented 1 year ago

Yes, I can fix it up,

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 :tada:

Comparison is base (f868e6d) 75.08% compared to head (1dc8802) 75.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #393 +/- ## ========================================== + Coverage 75.08% 75.22% +0.14% ========================================== Files 52 52 Lines 2797 2797 Branches 267 285 +18 ========================================== + Hits 2100 2104 +4 + Misses 530 509 -21 - Partials 167 184 +17 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `56.41% <0.00%> (ø)` | | | unit | `69.53% <100.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/lambdaisland/kaocha/pull/393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/kaocha/watch.clj](https://app.codecov.io/gh/lambdaisland/kaocha/pull/393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2thb2NoYS93YXRjaC5jbGo=) | `71.67% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/lambdaisland/kaocha/pull/393/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alysbrooks commented 1 year ago

Released in v1.83.1314

[lambdaisland/kaocha "1.83.1314"]                 ;; deps.edn
{lambdaisland/kaocha {:mvn/version "1.83.1314"}}  ;; project.clj