lambdaisland / kaocha

Full featured next gen Clojure test runner
https://cljdoc.org/d/lambdaisland/kaocha/
Eclipse Public License 1.0
803 stars 84 forks source link

Update Beholder to improve support for certain editors. #398

Closed alysbrooks closed 1 year ago

alysbrooks commented 1 year ago

Beholder released a fix for certain editors that create a new file and then delete instead of modify. I believe Vim and Neovim do this when noswapfile and either backupcopy=no or backupcopy=auto are set, but other editors probably do it too.

Sometimes these creation events would be dropped because the file exists already. I haven't noticed this problem when using --watch with Neovim, but it may depend on timing and thus may be highly platform-, version- or setup-specific. Also, I consider this a safe change to make without reproducing the initial issue.

codecov[bot] commented 1 year ago

Codecov Report

Base: 75.58% // Head: 75.58% // No change to project coverage :thumbsup:

Coverage data is based on head (b6e83cc) compared to base (fc532eb). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #398 +/- ## ======================================= Coverage 75.58% 75.58% ======================================= Files 51 51 Lines 2773 2773 Branches 262 262 ======================================= Hits 2096 2096 Misses 517 517 Partials 160 160 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `56.68% <ø> (ø)` | | | unit | `69.78% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alysbrooks commented 1 year ago

Released in v1.78.1249

[lambdaisland/kaocha "1.78.1249"]                 ;; deps.edn
{lambdaisland/kaocha {:mvn/version "1.78.1249"}}  ;; project.clj