Use colors that support both dark and light color schemes

[heralden]

The default colors used in kaocha test outputs aren't readable if you're using a light color scheme.

How about changing some of the colors so that they work for both dark and light color schemes?

[alysbrooks]

I think this makes a lot of sense (and eventually, we probably want to add customization options).

[plexus]

Note that this is really a deep-diff2 concern, can we file an issue there and link to it from here?

Agreed on configurability, it's going to be hard to please everyone when it comes to colors. In which case it could be a kaocha concern to expose those configuration options.

[alysbrooks]

I daresay this could also be an accessibility concern; I'm not sure our colors are colorblind friendly.

[alysbrooks]

As an update on what we've found/discussed: We use the standard terminal colors and they're ultimately set by the terminal emulator. We may add some functionality to make changing the color scheme of deep-diff2 easier, but it is already possible to make that change, so one of our next steps is enabling that configuration from Kaocha.

What I'm leaning toward is making three changes to Kaocha:

• A "fallback" option where we specify all colors and backgrounds to ensure good contrast. This would probably be dark mode, but maybe we could have both a light and dark fallback?
• A configuration option that would allow you to specify either named terminal colors or RGB codes (probably something via a syntax like [200 150 0] and :red). We could document some possible options (e.g., a light scheme or a solarized-inspired one).
• Respect the NO_COLOR environment variable: https://no-color.org/. It's not related to the original request, but a small change, and I think it's thematically related as it would allow Kaocha to accommodate more users' color preferences.

[plexus]

Thank you @alysbrooks , I like those proposals. Something I was also thinking about is that maybe we should have a scheme that people can easily switch to that's suitable for common forms of color blindness. The current red/green is pretty terrible in that regard. We currently don't really have any "global" kaocha config, but for something like this it would be useful to be able to configure this outside any specific project (eg a user config file or env var).