Closed humorless closed 1 year ago
Patch coverage: 60.00
% and project coverage change: -0.05
:warning:
Comparison is base (
f8775f2
) 75.13% compared to head (b85883d
) 75.08%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks, @humorless! Looks good.
I think adding your PR message (or a shorter version) to a comment would be good. If I remember correctly when I made the change, I looked around for comments and past commit messages but didn't find anything explaining why it was the way it was.
Thanks, @humorless! Looks good.
I think adding your PR message (or a shorter version) to a comment would be good. If I remember correctly when I made the change, I looked around for comments and past commit messages but didn't find anything explaining why it was the way it was.
Thanks for you suggestion. I have added the necessary comments to explain the bug.
Released in v1.84.1335
[lambdaisland/kaocha "1.84.1335"] ;; deps.edn
{lambdaisland/kaocha {:mvn/version "1.84.1335"}} ;; project.clj
Problem
From #416, there is a bug raised. The bug is because that Clojure's
*out*
is not totally equivalent to java'sSystem/out
. Clojure's*out*
is equivalent to System/out, wrapped in an OutputStreamWriter. Therefore, it caused a Casting error.Solution
After referencing how output capture is implemented in
src/kaocha/plugin/capture_output.cljc
, although I think there is already afinally
section, which should restore the java'sSystem/out
andSystem/err
, I tend to believe that Arne's comment is based on his real world experiments.