search

lambdaisland / kaocha

Full featured next gen Clojure test runner
https://cljdoc.org/d/lambdaisland/kaocha/
Eclipse Public License 1.0
803 stars 84 forks source link

Once Fixtures calling f multiple times #432

Closed NoahTheDuke closed 8 months ago

NoahTheDuke commented 8 months ago

:once fixtures that call the provided f multiple times can swallow failures if the last call passes. Instead of swapping out the results of the run-testables call each time (which discards the existing failures), we should conj all calls together and return that as the completed result.

Related to #388

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.16%. Comparing base (06b6b83) to head (a124899).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #432 +/- ## ========================================== + Coverage 75.15% 75.16% +0.01% ========================================== Files 52 52 Lines 2809 2811 +2 Branches 290 290 ========================================== + Hits 2111 2113 +2 Misses 511 511 Partials 187 187 ``` | [Flag](https://app.codecov.io/gh/lambdaisland/kaocha/pull/432/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/lambdaisland/kaocha/pull/432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `56.24% <100.00%> (+0.03%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/lambdaisland/kaocha/pull/432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `69.44% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

plexus commented 8 months ago

Thanks @NoahTheDuke , really appreciate the structured approach you're taking here. Is this good to be merged?

plexus commented 8 months ago

Oh and could you please add a change log entry? Thanks!

NoahTheDuke commented 8 months ago

Excepting the change log entry, I believe it is.

plexus commented 8 months ago

Much appreciated!

plexus commented 8 months ago

This has been released in 1.88.1376.