lambdaisland / ornament

Clojure Styled Components
Mozilla Public License 2.0
118 stars 13 forks source link

[WIP] bump girouette #19

Closed oxalorg closed 1 year ago

oxalorg commented 2 years ago

This PR updates griouette to v0.0.10 while still mainting backward compat

i.e. ornament will still be using Tailwind v2 bindings in girouette instead of using the updated Tailwind v3 functions.

In v0.0.8 girouette made some breaking changes. Look #18 for more info

plexus commented 2 years ago

Seems we don't need much to be able to let the user opt-in to v3

Can we make that classname function configurable? And then document in the readme what it would look like if someone wants to opt-in to v3?

GetBitOutdoors commented 2 years ago

There is a bug (from formatting?): (:require) terminates early https://github.com/lambdaisland/ornament/blob/a0f96cdb6f74d2bf9a26117582bcf41e28ba9167/src/lambdaisland/ornament.cljc#L4

plexus commented 1 year ago

Thanks @GetBitOutdoors, that should be fixed now.

plexus commented 1 year ago

2022-09-19_105139_firefox-nightly

One failing test.

daaku commented 1 year ago

Any chance of getting this into a release? Being able to use the current version of girouette would be nice.

plexus commented 1 year ago

Released in

[com.lambdaisland/ornament "0.7.77"]
{com.lambdaisland/ornament {:mvn/version "0.7.77"}}