search

lambdaisland / uri

A pure Clojure/ClojureScript URI library
Mozilla Public License 2.0
243 stars 21 forks source link

add `absolute?` #2

Closed jjl closed 7 years ago

jjl commented 7 years ago

It's really useful. The library I've just replaced with uri (exploding fish) had it.

plexus commented 7 years ago

Thanks for the patch! However isn't this counterintuitive? I would expect such a function to check whether the URL is qualified (contains a scheme and host), and not just the path.

Is this how it works in exploding fish?

On Mar 8, 2017 15:51, "jjl" notifications@github.com wrote:

It's really useful. The library I've just replaced with uri (exploding fish) had it.

You can view, comment on, or merge this pull request online at:

https://github.com/lambdaisland/uri/pull/2 Commit Summary

  • add absolute?

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lambdaisland/uri/pull/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB91BWyYUlGaoZ1WyHV63FCvLikYUcJks5rjsBggaJpZM4MW349 .

jjl commented 7 years ago

I hadn't really given it much thought to be honest.

It seems they check the authority https://github.com/wtetzner/exploding-fish/blob/master/src/org/bovinegenius/exploding_fish.clj#L552

plexus commented 7 years ago

yeah that seems like a better approach. Why did you choose to migrate away from exploding fish?

On Mar 8, 2017 18:29, "jjl" notifications@github.com wrote:

I hadn't really given it much thought to be honest.

It seems they check the authority https://github.com/wtetzner/ exploding-fish/blob/master/src/org/bovinegenius/exploding_fish.clj#L552

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lambdaisland/uri/pull/2#issuecomment-285090858, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB91LzgAGFf95LQ1SZyWOtsfUU8uGRvks5rjtdtgaJpZM4MW349 .

jjl commented 7 years ago

I don't remember at this point. the decision was made some time ago and i was waiting to discover something else to try instead. Yesterday, I tried uri.