Fix normalize-query for utf-16

FiV0 commented 2 years ago

Hi @Gaiwan,

Something like

(require '[lambdaisland.uri :as uri])
(require '[lambdaisland.uri.normalize :as n])

(n/normalize (uri/uri "https://twitter.com/intent/tweet?text=You are welcome 🙂&url=https://lambdaisland.com"))

will currently fail as normalize-query currently does not take utf-16 chars into account.

The patch only fixes the normalize-query part, something like

(n/char-seq (subs "🙂" 0 1))

will still fail. I wasn't quite sure how you want to deal with edge cases like these.

[x] the CHANGELOG, you can add an entry at the top underneath "Unreleased"
[ ] ~the README and other documentation~
[x] the tests, at least run them yourself before submitting (usually a bin/kaocha will do)

I ran bin/kaocha once.

plexus commented 2 years ago

Thanks @FiV0 , looks good!

plexus commented 2 years ago

Released in 1.11.86

lambdaisland / uri

Fix normalize-query for utf-16 #23