lambdaisland / uri

A pure Clojure/ClojureScript URI library
Mozilla Public License 2.0
243 stars 21 forks source link

Run CI for PRs from third party branches #32

Closed plexus closed 2 years ago

plexus commented 2 years ago

It seems we currently don't run CI on PRs originating from branches on forked repositories. I think this is a Circle CI setting, to prevent leaking secrets, but there are no secrets to leak here. We should fix that, and also review other projects to make sure that if we get contributions the tests actually run.

plexus commented 2 years ago

Added this to the Clojurists Together project board even though URI is not officially in scope for this dev cycle, but we should also check the testing-related repos to make sure this is configured correctly.

borkdude commented 2 years ago

Project settings -> Advanced Settings -> Flip the switch at Build forked pull requests

Screenshot 2022-10-10 at 11 57 28

This doesn't pass secrets to PR builds unless you also flip the switch below.

alysbrooks commented 2 years ago

Thanks @borkdude!