search

lambdalisue / django-inspectional-registration

Django registration app with Inspection before activation
http://pypi.python.org/pypi/django-inspectional-registration
42 stars 26 forks source link

Fixes #75 "Use email other than settings.DEFAULT_FROM_EMAIL". #76

Closed mick-t closed 7 years ago

mick-t commented 8 years ago

See https://github.com/lambdalisue/django-inspectional-registration/issues/75

lambdalisue commented 8 years ago

Please fix the code to pass CI and what I pointed. I'm ok to add a new variable but I don't like to make the previous way deprecated.

mick-t commented 7 years ago

@lambdalisue I updated the code with your suggestions. Thanks for making me aware of get()! 👍

I agree that the previous method should not be deprecated.

lambdalisue commented 7 years ago

Oops. I'm really sorry I'm too Vimmer. The correct one should be getattr and get was a Vim's function...

mick-t commented 7 years ago

get() works. I tested it with and without the REGISTRATION_FROM_EMAIL in the settings file.

lambdalisue commented 7 years ago

https://travis-ci.org/lambdalisue/django-inspectional-registration/jobs/174312048#L225

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 90.411% when pulling ddbc8c5d58d161eeeab34d8b1c22a780627da110 on mick-t:master into 19fa9d7862916bb75199b25c81c4c220d3e50672 on lambdalisue:master.

mick-t commented 7 years ago

Looks like nothing breaks this time! :)

lambdalisue commented 7 years ago

LGTM Thanks!

lambdalisue commented 7 years ago

I'll upload a new version which include this commit tonight. Ping me if I forget about this