search

lambdalisue / django-inspectional-registration

Django registration app with Inspection before activation
http://pypi.python.org/pypi/django-inspectional-registration
42 stars 26 forks source link

This is a minor change where typos and English grammatical mistakes are #9

Closed mick-t closed 10 years ago

mick-t commented 10 years ago

Hello,

Thanks for creating django-inspectional-registration, I'm guessing your not a native English speaker and this pull request should fix some minor issues and misspellings and some grammar mistakes in the source files. I haven't looked at the docs and may do update them in a different pull request.

I was changing the words used in the admin as my users mentioned that some of the wording was a little unusual. While I was doing so, I thought I may as well update all of the files. I hope you find this useful and agree with my changes and rewording of some of the text.

Regards Mick

lambdalisue commented 10 years ago

Wow, thanks a lot!

But unfortunately, I changed a lot of things yesterday for supporting Python 3.2-3.3 and Django 1.5, 1.6. It seems your modification was based on the old codes, so it will take times to merge this request because I need to confirm the changes by each.

But anyway this request helped me a lot! I'll merge it as soon as possible. Thanks again :-)

mick-t commented 10 years ago

Don't accept this pull yet. Let me know when you update Github with your latest code and and I'll merge those changes into my code and then update/fix any typo? Does that sound like a plan?

lambdalisue commented 10 years ago

It so nice! Thanks a lot :-) Well things are already updated in my master repository actually. If you are seeing version 0.3.1, that means you are seeing latest version :-)

Thanks again.

mick-t commented 10 years ago

Great, thanks for that. I'll close this pull request.