lambdalisue / jupyter-vim-binding

Jupyter meets Vim. Vimmer will fall in love.
2.1k stars 136 forks source link

js throws exception in Jupyter browser after loaded the vim-binding pulgin #105

Closed dahakawang closed 7 years ago

dahakawang commented 7 years ago

Summary

the plugin failed to load and with exception, and binding not working.

Loading extension: vim_binding/vim_binding
shortcuts.js?v=20170625214631:161 Uncaught (in promise) TypeError: Cannot read property 'data' of undefined
    at Object.attach (shortcuts.js?v=20170625214631:161)
    at Object.attach (vim_binding.js?v=20170625214631:63)
    at vim_binding.js?v=20170625214631:58
    at <anonymous>

Environment

Behavior

binding not working

Expected

binding should work

Actual

not working, and can see exception throws in the broswer console

Step by step procedure

nothing special, installed the plugin, and it's just not working when opened jupyter

What you have done to solve the issue

Both FF and chrome has the same issue

Remarks

part of the contexts before it throws: as you can see, somehow km.config is undefined, so next statement will cause exception throw. not familiar with the code base, really appreciate if you guys can help to troubleshooting. I can provide any information regarding this for further investigation...

111

lambdalisue commented 7 years ago

Thanks for the report. It seems a bug introduced from https://github.com/lambdalisue/jupyter-vim-binding/pull/103

I'll fix it soon.

lambdalisue commented 7 years ago

It should be fixed by https://github.com/lambdalisue/jupyter-vim-binding/commit/119bb4544ae1c8922c417c28774d8a091d45856b

Please feel free to reopen the issue if the problem remains 👍

dahakawang commented 7 years ago

it works now, thank you!