lambdalisue / jupyter-vim-binding

Jupyter meets Vim. Vimmer will fall in love.
2.1k stars 136 forks source link

Erroneous Ex commands (e.g., :asdf) breaks vim bindings #107

Open slundqui opened 7 years ago

slundqui commented 7 years ago

Summary

Typing an erroneous ex command breaks vim bindings.

Environment

Behavior

Once you type an erroneous ex command, navigation between code cells no longer work until you click on a cell with the mouse. Even after clicking in a cell, navigating within a cell changes the notebook cell focus while staying in insert mode within the clicked cell.

Expected

Vim bindings should work after erroneous ex commands

Actual

Vim bindings break after erroneous ex commands

Step by step procedure

  1. Start local Jupyter Notebook by jupyter notebook
  2. Access http://localhost:8888/
  3. Make multiple cells (shift-esc, o, o, o)
  4. Focus into a cell in the middle (k, i)
  5. Enter erroneous ex command (:asdf)
  6. Attempt to navigate to other cells (j, k)

What you have done to solve the issue

Reproduced with another machine (also running ubuntu, chrome browser)

lambdalisue commented 7 years ago

So you mean it seems errneous ex command somehow reset the mappings completly, right? While the plugin does not provide ex commands well, that kind of behaviors are not really tested sorry.

Currently I can get enough time to investigate it so please be patient or send me a pr :+1:

lambdalisue commented 7 years ago

s/I can/I can't