search

lambdalisue / jupyter-vim-binding

Jupyter meets Vim. Vimmer will fall in love.
2.1k stars 136 forks source link

<esc> returns to Jupyter Mode instead of vim mode in vivaldi #112

Open SamCB opened 7 years ago

SamCB commented 7 years ago

Summary

Escape doesn't work as expected.

Environment

Behavior

Expected

In Insert Mode, pressing escape should return you to vim mode.

Actual

In Insert Mode, pressing escape returns you to jupyter mode.

Step by step procedure

  1. Start local Jupyter Notebook by jupyter notebook
  2. Access http://localhost:8888/ in Vivaldi
  3. Open an existing notebook
  4. With a cell activated, enter insert mode (e.g. press i twice)
  5. Press <esc>, you are immediately taken out of vim mode, there is no cursor.

What you have done to solve the issue

I've tried turning off all extensions (Moly Keys, Moly HaH, LastPass, Google Docs Offline) also running in private mode with no success.

I've compared this with Chrome (60.0.3112.113) running the exact same server and exact same notebook. It works as expected there.

lambdalisue commented 7 years ago

Confirmed. I'll investigate. The workaround is using Ctrl-[ instead of Esc like the native Vim.

lambdalisue commented 7 years ago

Well... I have no idea for this issue for now... Prob. further deep investigation is required but I don't have enough time and motivations sorry...

ref. #89

DrJimFan commented 7 years ago

Since I don't use Vivaldi browser, this doesn't answer your question. But I see exactly the same weird behavior with <Esc> key in my Chrome browser. For future visitors to this issue: disable all extensions and try again. I solved my problem by disabling a specific plugin called Vimium. I forgot to whitelist the domain localhost:*.

mik13ST commented 6 years ago

I have the same problem. I am using Vivaldi on Archlinux, however disabling all extensions did not solve the issue. It works fine in Chromium. EDIT: Possible hotfix is specifying the default browser in Jupyter to e.g. Chromium: https://stackoverflow.com/questions/35229604/how-to-change-the-default-browser-used-by-the-ipython-jupyter-notebook-in-linux

harshhpareek commented 6 years ago

I am having this issue as well. Does anyone have any ideas about how to fix this in the binding? (Don't have much experience with this type of code, but could try)

SamCB commented 6 years ago

@harshhpareek I've stopped using Vivaldi, however if I remember correctly, one of the things I did find was that the error is not jupyter-vim-binding specific, but is also found in CodeMirror's vim bindings. Since CodeMirror is used for this plugin, it would most likely need to be fixed there. Given CodeMirror doesn't seem to officially support Vivaldi, I'm not sure how easy fixing it here is going to be.

harshhpareek commented 6 years ago

Thanks! I might consider posting a bug report with vivaldi. I quite like it

On Thu, May 3, 2018, 5:01 PM Sam Collis-Bird notifications@github.com wrote:

@harshhpareek https://github.com/harshhpareek I've stopped using Vivaldi, however if I remember correctly, one of the things I did find was that the error is not jupyter-vim-binding specific, but is also found in CodeMirror's vim bindings https://codemirror.net/demo/vim.html. Since CodeMirror is used for this plugin, it would most likely need to be fixed there. Given CodeMirror doesn't seem to officially support Vivaldi, I'm not sure how easy fixing it here is going to be.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lambdalisue/jupyter-vim-binding/issues/112#issuecomment-386471841, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBxmbZBRUHB5uO2ViwvKvVrEHN0zh8Mks5tu5pygaJpZM4PPICT .

-- Harsh Pareek | Graduate Student | Computer Science | UT Austin http://www.cs.utexas.edu/~harshp | +1 (512) 994-5775

GetCurious commented 5 years ago

gosh i thought this is bugging me. it's either this or chrome's Ctrl-n