Remove trailing commas from parameter list in lib/jupyter/shortcuts.js - Githubissues

lambdalisue / jupyter-vim-binding

Jupyter meets Vim. Vimmer will fall in love.

2.1k stars 136 forks source link

Remove trailing commas from parameter list in lib/jupyter/shortcuts.js #113

Closed Exiledz closed 6 years ago

Exiledz commented 6 years ago

Trailing commas in parameter lists are currently only supported by firefox according to the following reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas

This broke me on chrome 55.0.2883.75 (64-bit).

This PR is for

[ ] Fix a reported issue : #XXX
[x] Fix a unreported issue : Write summary in a new section
[ ] Add a reported feature implement : #XXX
[ ] Add a unreported feature implement : Write summary in a new section
[ ] Other : Write summary in a new section

Summary

Trailing commas in parameter lists are currently only supported by firefox according to the following reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas

This broke me on chrome 55.0.2883.75 (64-bit)

lambdalisue commented 6 years ago

Thanks a lot 👍