Support for notebooks in JupyterLab

joelostblom commented 6 years ago

Hi, I have recently started using the Jupyter Notebook again, and you plugin really is fantastic! Thanks for making it!

I am curious if you have any plans to support this plugin with notebooks in the new JupyterLab. I know it's only in beta release right now, so I am just wondering if you think you will be adding support in the future or if it will be too much work to be worthwhile.

stsievert commented 6 years ago

The jupyterlab developers are considering adding vim support: https://github.com/jupyterlab/jupyterlab/issues/1362

joelostblom commented 6 years ago

@stsievert Thanks for the heads up!

lambdalisue commented 6 years ago

Thanks for comment.

Well, I know JupyterLab and I was really looking forward that project. However, as I mentioned in https://github.com/lambdalisue/jupyter-vim-binding/issues/89, recently I changed job and I no longer use jupyter notebook unfortunately. That's why I'm not really welcome to support the new platform in this plugin by myself.

As I said I'm welcome to add contributors, I don't have any negative image for supporting jupyterlab if someone takes care. Or this is MIT plugin so I'm OK if someone use core parts of this plugin in new plugins or jupyterlab itself as long as they read and follow the license :smile:

joelostblom commented 6 years ago

Thanks for replying although you don't work on this anymore! I looked more into jupyter lab, it has some nice features, but nothing that I think is better than vim-bindings =) So I will keep using the standalone notebook with your addon.

jmeppley commented 6 years ago

FWIW, I have this extension working in JupyterLab. I'm not sure how stable it will be, but it's working.

I did something like this:

created my own personal conda environemnt with jupyter and the jupyter_nbextensions_configurator package.

then I followed the enabled use extensions with

jupyter nbextensions_configurator enable --user

then I installed using the instructions in the Readme:

# Create required directory in case (optional)
mkdir -p $(jupyter --data-dir)/nbextensions
# Clone the repository
cd $(jupyter --data-dir)/nbextensions
git clone https://github.com/lambdalisue/jupyter-vim-binding vim_binding
# Activate the extension
jupyter nbextension enable vim_binding/vim_binding

This is a little bit of black magic, but it seems to work on two different JupyterHubs I use: one that has the extension manager installed and one that doesn't.

stsievert commented 6 years ago

Can you put in a PR so I can evaluate? I don't maintain this repo but am interested. Also, there is another vim extension for jupyterlab: https://github.com/jwkvam/jupyterlab-vim.

jmeppley commented 6 years ago

I made no code changes. I had an old install that just worked when our sysadmin setup jupyterlab.

I hadn't seen jupyterlab-vim. That looks like it has the features I need, thanks!

On Wed, May 9, 2018 at 3:25 PM, Scott Sievert notifications@github.com wrote:

Can you put in a PR so I can evaluate? I don't maintain this repo but am interested. Also, there is another vim extension for jupyterlab: https://github.com/jwkvam/jupyterlab-vim.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lambdalisue/jupyter-vim-binding/issues/114#issuecomment-387893922, or mute the thread https://github.com/notifications/unsubscribe-auth/ABo37Fl9xkf77UObxExKpoCCxeRezkqvks5tw2zvgaJpZM4PpbAA .

jmeppley commented 6 years ago

Oh.

I just realized I was confusing JupyterLab and JupyterHub again. I have it working for jupyter hub. Nevermind.

On Wed, May 9, 2018 at 3:28 PM, John Eppley jmeppley@gmail.com wrote:

I made no code changes. I had an old install that just worked when our sysadmin setup jupyterlab.

I hadn't seen jupyterlab-vim. That looks like it has the features I need, thanks!

On Wed, May 9, 2018 at 3:25 PM, Scott Sievert notifications@github.com wrote:

Can you put in a PR so I can evaluate? I don't maintain this repo but am interested. Also, there is another vim extension for jupyterlab: https://github.com/jwkvam/jupyterlab-vim.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lambdalisue/jupyter-vim-binding/issues/114#issuecomment-387893922, or mute the thread https://github.com/notifications/unsubscribe-auth/ABo37Fl9xkf77UObxExKpoCCxeRezkqvks5tw2zvgaJpZM4PpbAA .

lambdalisue / jupyter-vim-binding

Support for notebooks in JupyterLab #114