search

lambdalisue / jupyter-vim-binding

Jupyter meets Vim. Vimmer will fall in love.
2.1k stars 136 forks source link

changed cell output shortcut in jupyter #20

Closed wilzbach closed 8 years ago

wilzbach commented 8 years ago

Apparently the guys from IPython renamed the action shortcuts, see:

https://github.com/jupyter/notebook/pull/692 https://github.com/jupyter/notebook/blob/master/notebook/static/notebook/js/actions.js

(with the wrong shortcut name, the extension is failing to load, maybe we should address this is a different issue?)

lambdalisue commented 8 years ago

Thanks a lot :-)

with the wrong shortcut name, the extension is failing to load, maybe we should address this is a different issue?

Probably I should use add_shortcuts instead of add_shortcut and wrap with try block.

https://github.com/jupyter/notebook/blob/1d934b3a9a25d1ff7e26d0f2bd07946d3c6f5505/notebook/static/base/js/keyboard.js#L382 https://github.com/jupyter/notebook/blob/1d934b3a9a25d1ff7e26d0f2bd07946d3c6f5505/notebook/static/notebook/js/keyboardmanager.js#L63