search

lambdalisue / jupyter-vim-binding

Jupyter meets Vim. Vimmer will fall in love.
2.1k stars 136 forks source link

ESC takes you to Jupyter's command mode in Safari. #65

Closed ElDeveloper closed 8 years ago

ElDeveloper commented 8 years ago

Summary

Hitting <Esc> takes me to Jupyter's command mode in Safari, Chrome however works just fine.

Environment

Hitting <Esc> takes me to Jupyter's command mode in Safari, Chrome however works just fine.

Expected

It shouldn't take me to Jupyter's command mode.

Actual

It takes me to Jupyter's command mode.

Step by step procedure

  1. Start local Jupyter Notebook by jupyter notebook
  2. Access http://localhost:xxxx/ in Safari
  3. Enter insert mode in a cell, then hit <Esc>, you will be taken to Jupyter's command mode.

    What you have done to solve the issue

For example, the behavior is confirmed with Safari 9.0.3 and could not be reproduced in Firefox but Chrome.

lambdalisue commented 8 years ago

Thanks! ok, I'll check it prob next week. ping me if no further responce after next week :-)

ElDeveloper commented 8 years ago

Friendly ping.

lambdalisue commented 8 years ago

Thanks and sorry for late reply.

I tried with Safari Version 9.0.3 (11601.4.4) on OS X El Capitan (10.11.3) + jupyter-vim-binding ad4e35e on Jupyter 4.2 and found:

So it seems that the situation is a bit different from yours. In my case, none of Vim mappings worked even in CodeMirror's Vim mode it self, mean that jupyter-vim-binding can not support Safari somehow.

Which exact version of Safari did you use? Not sure why CodeMirror's Vim mode itself does not work in my Safari...

ElDeveloper commented 8 years ago

@lambdalisue, thanks for looking into this. I'm using Version 9.1 (11601.5.17.1) in OS X El Capitan 10.11.4.

When I go to the example in the code mirror website, I can move around the text and even enter insert mode, but as soon as I hit <Esc> to exit insert mode, the text-box itself seems to no longer be in focus and I'm no longer able to execute any vim command. I think this points that the problem is CodeMirror itself not jupyter-vim-binding.

I also noticed this in there:

The CodeMirror vim bindings do not have an active maintainer.

lambdalisue commented 8 years ago

but as soon as I hit to exit insert mode, the text-box itself seems to no longer be in focus and I'm no longer able to execute any vim command. I think this points that the problem is CodeMirror itself not jupyter-vim-binding.

I see. Then jupyter-vim-binding does not work in Safari.

ElDeveloper commented 8 years ago

Thanks for looking into this.

ElDeveloper commented 8 years ago

Just FYI, I finally figured it out, another plugin was interfering with bindings, I deactivated it and it was all good.