search

lambdalisue / jupyter-vim-binding

Jupyter meets Vim. Vimmer will fall in love.
2.1k stars 136 forks source link

RFC: eval markdown when leaving a cell #85

Closed jwkvam closed 7 years ago

jwkvam commented 8 years ago

This PR is for

This PR evaluates markdown when leaving a cell. I only captured the most common cases I use (j, k, ctrl-j, and ctrl-k) and I realize there are others e.g. ctrl-o, o. I did this because I find it annoying when I'm navigating through my notebook with the controls above and all my markdown is left unrendered. This seems to work for me, do others like it?

lambdalisue commented 8 years ago

I would like to ask what people think about this change. I personally feel it is too much but ...

jwkvam commented 8 years ago

Not much feedback :( oh well. One my motivating use cases was to keep the toc2 extension functional. If the markdown isn't rendered, the links in the plugin don't work.

Doesn't seem like we're gonna get any comments. So I'm fine maintaining this myself.

lambdalisue commented 8 years ago

Hum... Sad.

I just personally feel too much so I'm ok to merge this if the behaviour is configurable. Unfortunately, there is a tough bug which prevent users to customize mappings.

I"ll merge this once the issue above is solved.

jgors commented 7 years ago

I would like to see this merged. This seems like a great feature as it is a bit of a pain to have to (re)run each markdown cell after just navigating through it with j/k motions.

lambdalisue commented 7 years ago

I'm sorry to take a time to merge this. @jwkvam

I would like to fix an issue first but I don't really think I have enough time to investigate that so I decided to merge this.

Thanks to reminds me @jgors