Ctrl-s opens up the save window when in Vim mode, but not when exited

[darthdeus]

Summary

Ctrl-s doesn't work in Vim mode, but works outside it.

Environment

• [x] Operating system : Windows 10 x64
• [x] Web browser : Chrome 57.0.2987.133
• [x] Version or revision of Jupyter Notebook : 4.3.1, Python 2.7.13 |Anaconda 4.3.1 (64-bit)| (default, Dec 19 2016, 13:29:36) [MSC v.1500 64 bit (AMD64)]
• [x] Revision of jupyter-vim-binding : 296ef3a

Behavior

Pressing Ctrl-s in Vim mode opens up the browser save menu

Expected

Expecting it to save a checkpoint as it does if I exit Vim mode (shift-escape)

Actual

Step by step procedure

1. Start local Jupyter Notebook by jupyter notebook
2. Access http://localhost:8888/
3. Press Ctrl-s to save and see that it saves a checkpoint
4. Press i to enter Vim mode
5. Press Ctrl-s again and a Chrome opens up a save dialogue

What you have done to solve the issue

I tried this both in Chrome 57.0.2987.133 and Firefox 53.0 (32bit) and it is reproducible in both.

[lambdalisue]

Vim does not use Ctrl-s. If you prefer, add a custom mapping for that