lambdalisue / vim-fall

🍂 Another fuzzy finder designed for Vim and Neovim and implemented in Denops
https://jsr.io/@lambdalisue/vim-fall
MIT License
41 stars 2 forks source link

PoC #1

Closed lambdalisue closed 7 months ago

lambdalisue commented 7 months ago

https://github.com/vim-fall/fall.vim/assets/546312/cf522962-f54f-48d8-a636-064b02f94935

Shougo commented 7 months ago

It seems broken. When I execute Fall file or Fall line test.vim:

[denops] Failed to handle message 2,invoke,dispatch,fall,startCommand,line,test.vim TypeError: Cannot read properties of undefined (reading 'width')
[denops]     at new ItemsPicker (file:///home/shougo/src/fall.vim/denops/fall/ui/items_picker.ts:83:21)
[denops]     at start (file:///home/shougo/src/fall.vim/denops/fall/start.ts:74:23)
[denops]     at eventLoopTick (ext:core/01_core.js:166:7)
[denops]     at async startCommand (file:///home/shougo/src/fall.vim/denops/fall/command.ts:47:3)
[denops]     at async Object.startCommand (file:///home/shougo/src/fall.vim/denops/fall/main.ts:26:7)
[denops]     at async Plugin.call (file:///home/shougo/work/denops.vim/denops/@denops-private/service.ts:138:12)
[denops]     at async Service.#dispatch (file:///home/shougo/work/denops.vim/denops/@denops-private/service.ts:68:12)
[denops]     at async Service.dispatch (file:///home/shougo/work/denops.vim/denops/@denops-private/service.ts:73:14)
[denops]     at async dispatch (https://deno.land/x/messagepack_rpc@v2.0.3/dispatcher.ts:36:12)
[denops]     at async Session.#dispatch (https://deno.land/x/messagepack_rpc@v2.0.3/session.ts:244:22)
lambdalisue commented 7 months ago

Just wait. Maybe things are not fully loaded.

Shougo commented 7 months ago

Same thing.

Shougo commented 7 months ago
export const defaultParams: SetupParams = {
  picker: {
    items: {
      "": {
        defaultAction: "open",
        actions: ["debug", "echo", "open", "open:*"],
        filters: ["substring"],
        sorters: ["lexical", "lexical:desc"],
        presenters: [],
        previewer: "path",
      },
      "line": {
        sorters: [],
        presenters: [],
      },
    },
    action: {
      filters: ["substring"],
      sorters: ["lexical", "lexical:desc"],
      presenters: [],
    },
  },

itemsPickerDefault.params is not defined in default.ts.

Shougo commented 7 months ago

Confirmed. The bug is fixed.