lambdalisue / vim-fern-renderer-nerdfont

🌿 fern.vim plugin which add file type icon through nerdfont.vim
MIT License
79 stars 12 forks source link

Icons are broken for me since latest update #26

Closed jclsn closed 10 months ago

jclsn commented 10 months ago

The icons are broken since the last update

image

Some are too small, some have a prepended letter and some have double icons

Seems like this commit has broken it

https://github.com/lambdalisue/fern-renderer-nerdfont.vim/commit/e472ea1b57c39a651fe0fee3907fbfc5ad296446

lambdalisue commented 10 months ago

Did you update https://github.com/lambdalisue/nerdfont.vim? If you didn't, just update it. If you did and somehow it break, please find a minimal reproduction steps (including information about OS, Vim, Terminal, Shell, and vimrc)

jclsn commented 10 months ago

All plugins got updated together

OS: Manjaro Vim: 9.0 1-2143 Terminal: Kitty, Alacritty, Konsole Shell: zsh, bash vimrc: I could strip my .vimrc down to this and the problem still occurs

call plug#begin('~/.vim/plugged')
        Plug 'lambdalisue/fern.vim'
        Plug 'lambdalisue/fern-renderer-nerdfont.vim'
        Plug 'lambdalisue/glyph-palette.vim'
        Plug 'lambdalisue/nerdfont.vim'
call plug#end()

let g:fern#renderer = "nerdfont"

nnoremap <silent> <C-n> :Fern . -drawer -toggle<CR>
jclsn commented 10 months ago

After opening the fern buffer even my terminal is broken and the cursor is below the home button. Only when I use zsh with p10k there though. No issues with bash. I have now downgraded fern.vim, fern-nerdfont-renderer.vim and nerdfont.vim as far as I can and now all my problems are gone.

I have now frozen all of your plugins. Please let me know when you think you have found a fix and I am happy to test it.

lambdalisue commented 10 months ago

@jclsn

It seems that this issue is environment-dependent, making reproduction very challenging. However, since the behavior of something that was previously working is now disrupted, we have changed the approach of the relevant feature of the nerdfont from opt-out to opt-in, as it goes against the plugin-providing policy. The fern-renderer-nerdfont.vim has been reverted to its original state.

Thank you for providing detailed feedback.

jclsn commented 10 months ago

I can confirm that this fixes the issue. Seems like it really was just this one commit. Weird that I had to also reset nerdfont.vim before. Seems to work now though.

If there is anything I can test in the future, don't hesitate to ask!

fvdnabee commented 10 months ago

I experienced the same padding issue as OP (and am also a powershell 10k user). Just wanted to add that the revert to fern renderer NF also fixed the issue in my case.