search

lambdalisue / vim-gina

👣 Asynchronously control git repositories in Neovim/Vim 8
http://www.vim.org/scripts/script.php?script_id=5531
MIT License
687 stars 27 forks source link

Gina freezes when integrated into the statusline with git version 2.18.0 #179

Closed wimstefan closed 6 years ago

wimstefan commented 6 years ago

That's the error message showing up after pressing Ctrl-C

Error detected while processing function MyStatusline[25]..gina#component#status#preset[6]..<SNR>135_preset_fancy[1]..gina#component#status#staged[5]..<SNR>135_status_count[6]..gina#process#c
all[6]..gina#process#open[10]..<SNR>138_build_raw_args[9]..gina#core#askpass#wrap[5]..<SNR>144_askpass[1]..gina#core#repo#config:
line    9:
E605: Exception not caught: vital: App.Revelator: ERROR: Fail: git --no-pager -c core.editor=false -c color.status=always -C /home/swimmer/.dotfiles config --list
Error detected while processing function MyStatusline:
line   25:
E171: Missing :endif

You can find the code how I create the statusline in vim here -> https://github.com/wimstefan/dotfiles/blob/master/vim/vimrc#L470-L511

wimstefan commented 6 years ago

vim --version

VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep 11 2018 13:55:16)
Included patches: 1-366
Modified by Gentoo-9999
Compiled by swimmer@swimmer
Huge version without GUI.  Features included (+) or not (-):
+acl               +extra_search      +mouse_netterm     +tag_old_static
+arabic            +farsi             +mouse_sgr         -tag_any_white
+autocmd           +file_in_path      -mouse_sysmouse    -tcl
+autochdir         +find_in_path      +mouse_urxvt       +termguicolors
-autoservername    +float             +mouse_xterm       +terminal
-balloon_eval      +folding           +multi_byte        +terminfo
+balloon_eval_term -footer            +multi_lang        +termresponse
-browse            +fork()            -mzscheme          +textobjects
++builtin_terms    +gettext           +netbeans_intg     +timers
+byte_offset       -hangul_input      +num64             +title
+channel           +iconv             +packages          -toolbar
+cindent           +insert_expand     +path_extra        +user_commands
+clientserver      +job               +perl              +vartabs
+clipboard         +jumplist          +persistent_undo   +vertsplit
+cmdline_compl     +keymap            +postscript        +virtualedit
+cmdline_hist      +lambda            +printer           +visual
+cmdline_info      +langmap           +profile           +visualextra
+comments          +libcall           -python            +viminfo
+conceal           +linebreak         +python3           +vreplace
+cryptv            +lispindent        +quickfix          +wildignore
-cscope            +listcmds          +reltime           +wildmenu
+cursorbind        +localmap          +rightleft         +windows
+cursorshape       -lua               -ruby              +writebackup
+dialog_con        +menu              +scrollbind        +X11
+diff              +mksession         +signs             +xfontset
+digraphs          +modify_fname      +smartindent       -xim
-dnd               +mouse             +startuptime       -xpm
-ebcdic            -mouseshape        +statusline        +xsmp_interact
+emacs_tags        +mouse_dec         -sun_workshop      +xterm_clipboard
+eval              +mouse_gpm         +syntax            -xterm_save

I have to add that it doesn't happen with NVIM v0.3.2-497-gd6b3c0912

lambdalisue commented 6 years ago

~May related:~

~https://vim-jp.slack.com/archives/C03C4RC9F/p1536720963000100 https://vim-jp.slack.com/archives/C03C4RC9F/p1536737145000100~

~https://github.com/vim/vim/commit/94f01956a583223dafe24135489d0ab1100ab0ad https://github.com/vim/vim/commit/84d9390480548c8d711dd772cb162a91d0bb3c30~

I'll investigate it later thanks 👍

P.S. I found that the above links were different issues.

lambdalisue commented 6 years ago

Could you try https://github.com/lambdalisue/gina.vim/pull/180

wimstefan commented 6 years ago

Could you try #180

Thanks for looking into it! I first have to find out how I can merge that PR to try it out. Unfortunately I only have time to do that next week since I'm travelling and working the whole weekend. I'll report back as soon as possible!

lambdalisue commented 6 years ago

I found that the above links were different issues.

Actually it was. May fixed with https://github.com/lambdalisue/vital-Whisky/pull/9 and the change has applied to #180.

Related issues

https://github.com/vim-jp/issues/issues/1185 https://github.com/Shougo/dein.vim/issues/312

wimstefan commented 6 years ago

OK I finally found the time to look into it. After checking out the origin/fix-issues branch I can already report that the statusline is shown again and it seems that at least my issue is solved :)

Thanks a lot!