search

lambdalisue / vim-gina

👣 Asynchronously control git repositories in Neovim/Vim 8
http://www.vim.org/scripts/script.php?script_id=5531
MIT License
688 stars 27 forks source link

Gina commit not working on windows #229

Closed K1DV5 closed 4 years ago

K1DV5 commented 4 years ago

I made some changes, entered Gina status, and used -- to stage my changes and when I tried Gina commit, it gives me this error:

[gina] Fail: git --no-pager -c core.editor=false -c color.status=always -C D:\git\repo\path commit --edit
[gina] error: There was a problem with the editor 'false'.
[gina] Please supply the message using either -m or -F option.
lambdalisue commented 4 years ago

Could you tell me your git version, vim or neovim version?

K1DV5 commented 4 years ago

git version 2.23.0.windows.1 neovim 0.4.2

wsdjeg commented 4 years ago

@lambdalisue as I remember, it works well in old version of gina an git.

lambdalisue commented 4 years ago

@lambdalisue as I remember, it works well in old version of gina an git.

Yes. Prob the version of git is the matter but I'm not sure while I don't use Windows....

wsdjeg commented 4 years ago

Is there any update on this issue, I hope this plugin can be used in windows.

K1DV5 commented 4 years ago

Not so far, there are other issues as well.

lambdalisue commented 4 years ago

I'm not sure but maybe false is not a valid program on Windows and newer git complain that. What happens if you provide false.bat which always exit with 1 on your PATH?

K1DV5 commented 4 years ago

Tried using a false.bat which exits with both 1 and 0 but it still fails with the same message. Maybe the issue is not related with it.

lambdalisue commented 4 years ago

Prob fixed. Please try @K1DV5 @wsdjeg

ghost commented 4 years ago

I checked working well on Windows neovim !

K1DV5 commented 4 years ago

Yes, problem fixed, good job!!