Gina status not working as expected

lambdalisue / vim-gina

👣 Asynchronously control git repositories in Neovim/Vim 8

http://www.vim.org/scripts/script.php?script_id=5531

MIT License

689 stars 27 forks source link

Gina status not working as expected #234

Closed K1DV5 closed 4 years ago

K1DV5 commented 4 years ago

Typing -- in a Gina status buffer toggles the staging status of the file under the cursor (as it should) but it does not update the status buffer. When I reopen the status buffer, I get the updated status, so I know it does the git command in the background. It just has to update the status buffer.

And the << map does not work, it gives the error E21: Cannot make changes, 'modifiable' is off as if I tried to edit it.

lambdalisue commented 4 years ago

Which version of Vim, Git, Gina, and OS do you use? The feature you mentioned are working well in my environment (Neovim v0.4.3, Git 2.23.0, Gina 666852d, macOS) at least.

K1DV5 commented 4 years ago

git version 2.23.0.windows.1 neovim 0.4.3 Windows 10 1903

I guess windows support needs some time, let me try, where are the mappings handled?

lambdalisue commented 4 years ago

It's bit complicated.

mappings are defined https://github.com/lambdalisue/gina.vim/blob/master/ftplugin/gina-status.vim through actions
'index' actions are defined https://github.com/lambdalisue/gina.vim/blob/master/autoload/gina/action/index.vim
when command has executed (like :Gina add <something>), an internal modified:delay event is emitted
when modified:delay emits modified event, s:on_modified will be triggered and :edit will be trigged on all modified gina buffers like https://github.com/lambdalisue/gina.vim/blob/master/autoload/gina/core/emitter.vim#L27-L44

While everything works with Neovim on macOS, I'm guessing there is some timing issue or whatever on Windows. Not just like mapping problems.

lambdalisue commented 4 years ago

Ah, not sure but #229 may cause this issue.

rzeigler commented 4 years ago

If it is relevant. I have #229 but this issue only occurs in nvim-qt. When I execute from the terminal it works fine.

K1DV5 commented 4 years ago

I can confirm that it does work in the terminal. I always use nvim-qt so I didn't check it earlier.

lambdalisue commented 4 years ago

So the issue may be reproducable with

git version 2.23.0.windows.1 neovim 0.4.3 Windows 10 1903 nvim-qt (Which version?)

right?

K1DV5 commented 4 years ago

nvim-qt 0.2.14

I should point out that the << map issue is still there in nvim terminal. The -- map works.

rzeigler commented 4 years ago

Sorry, I think my above was unclear. I cannot commit (related error about false not being an editor). For me << works in terminal on windows.

lambdalisue commented 4 years ago

@K1DV5 So only << does not work in nvim-qt right? Then prob. https://github.com/equalsraf/neovim-qt/issues/134

K1DV5 commented 4 years ago

You're right, but since -- works now, it doesn't matter, can be considered fixed.