search

lambdalisue / vim-gina

👣 Asynchronously control git repositories in Neovim/Vim 8
http://www.vim.org/scripts/script.php?script_id=5531
MIT License
689 stars 27 forks source link

Fix a problem with fixup commit failing #267

Closed yuki-yano closed 4 years ago

yuki-yano commented 4 years ago

Environment

Problem

Gina commit --fixup {hash} opens a buffer for the commit and fails to save it, resulting in an error. Fixup commit doesn't need to open a buffer, so I think the behavior is incorrect.

Error: [gina] fatal: Only one of -c/-C/-F/--fixup can be used.

[gina] Fail: env GIT_TERMINAL_PROMPT=0 GIT_ASKPASS=/Users/user_name/dotfiles/.vim/bundle/.cache/init.vim/.dein/scripts/askpass.mac git --no-pager -c core.editor=false -c color.status=always
-C /Users/user_name/repos/github.com/yuki-ycino/fzf-preview.zsh commit --fixup 826e9482eeaa0a38f821fb4507721e87f7ae9960 --no-edit --cleanup=strip --file=/var/folders/9w/0mzs87p55y97ys6zlkcgk
ll40000gn/T/nvimviH7wC/1

Read the code and fix it to run as raw command if it has the --fixup option It appears to be working in my environment. Is there a problem with the changes?