Gina patch doesn't respect opener options?

lambdalisue / vim-gina

👣 Asynchronously control git repositories in Neovim/Vim 8

http://www.vim.org/scripts/script.php?script_id=5531

MIT License

689 stars 27 forks source link

Gina patch doesn't respect opener options? #277

Closed SanchayanMaity closed 3 years ago

SanchayanMaity commented 3 years ago

I currently have this setting

call gina#custom#command#option(
  \ 'patch', '--oneside',
  \ '--opener', 'botright split'
  \)

Yet, calling :Gina patch opens a new tab and doesn't respect either the oneside or the --opener option.

Am I doing something wrong? I have diffopt+=vertical as well. Ideally I would like INDEX and WORKTREE or HEAD as well to open in 3 way vertical splits at the bottom.

lambdalisue commented 3 years ago

Prob. you need to use the following

call gina#custom#command#option('patch', '--oneside')
call gina#custom#command#option('patch', '--opener', 'botright split')

SanchayanMaity commented 3 years ago

Thank you very much. This solves my issue. Closing the issue.