Cannot open gist file - Githubissues

lambdalisue / vim-gista

An alternative gist.vim, vim plugin which manipulate gists in Vim.

http://www.vim.org/scripts/script.php?script_id=4976

MIT License

156 stars 5 forks source link

Cannot open gist file #88

Open ichizok opened 3 years ago

ichizok commented 3 years ago

Vim-gista fails edit action.

Conditions

Vim: built with +python3 and without +python
Using cURL as HTTP client in vim-gista

Repro steps

:Gista list and select gist.

Expected: new buffer is opened and can edit gist content
Actual: empty buffer is opened and the error is shown:

vim-gista: 0:

Details

As far as I confirmed, since api.github.com returns HTTP/2 responses, Vim-gista fails to parse response headers.

https://github.com/lambdalisue/vim-gista/blob/master/autoload/vital/_vim_gista/Web/HTTP.vim#L209

Here checks HTTP/1\.\d\s then cannot handle HTTP/2, so fail to parse status;

https://github.com/lambdalisue/vim-gista/blob/master/autoload/gista/resource/remote.vim#L46-L48

res.status is always 0, an exception is thrown.

lambdalisue commented 3 years ago

Thanks for the issue report but please see https://github.com/lambdalisue/vim-gista/issues/89