lambdaloop / anipose

πŸœπŸ€πŸ’πŸšΆ A toolkit for robust markerless 3D pose estimation
http://anipose.org
BSD 2-Clause "Simplified" License
354 stars 67 forks source link

Documentation improvements for filters #42

Open ljahn opened 4 years ago

ljahn commented 4 years ago

Is your feature request related to a problem? Please describe. I'd like to use filtering (2D as well as 3D with distance constraints) but the description of the filter parameters is insufficient. While it is clear how to enable filters and what general kind of operation they will perform, I cannot find accurate descriptions of the filter parameters.

Describe the solution you'd like Please clarify these points in the documentation:

Additional context Maybe it's just me not finding these descriptions but I have looked here (parameter list) and here (tutorial). As well as in the source code here (anipose) and here (optimization function in aniposelib) which also gives no comments / explanation.

lambdaloop commented 4 years ago

You're right, these are not appropriately described. I'll have to put together an example for how each parameter affects the optimization in the docs

Sam-Kelly commented 4 years ago

Hi, I'm also trying to use your 3D triangulation optimisation methods. As I understand it, scale_smooth and scale_length are the scale factors for the 'limb length' and 'temporal' loss described in the paper.

What were the parameters you used to get good quality 3D points? (Like in figure 7 in the paper). And how did you decide on those parameters?

RiSpa5 commented 11 months ago

Hi, did you manage to understand more on the effects of different parameters for 2D and 3D filtering? As far as I can see there is still no documentation on the subject, or at least I wasn't able to find any!