search

lambdamusic / Ontospy

Python library and command-line interface for inspecting and visualizing RDF models aka ontologies.
http://lambdamusic.github.io/Ontospy/
MIT License
219 stars 52 forks source link

Restore instances getter #106

Closed ajnelson-nist closed 2 years ago

ajnelson-nist commented 2 years ago

Continuous Integration has been failing since some point in recent commits, due to one unit test hitting a .instances property and getting an unexpected type. git bisect running nosetests showed that 5a7aa82 was the first commit to fail since 0b2c06b.

This patch(-series?) restores a commented-out property getter body. I could not determine from the patch diffs or notes why that method was commented out, so if there is a practical reason, I'd be happy to explore alternatives to this PR. I am mainly looking to restore passing CI.

lambdamusic commented 2 years ago

Hi @ajnelson-nist thanks for the PR. Should be fixed with https://github.com/lambdamusic/Ontospy/releases/tag/v1.9.9.3 See more context on https://github.com/lambdamusic/Ontospy/issues/105

ajnelson-nist commented 2 years ago

Thank you for the explanation!