search

lambdapioneer / argon2kt

An Android/Kotlin binding for the Argon2 hash
MIT License
78 stars 8 forks source link

Add support for 16kB page size in Android 15 #23

Closed tomkricensky closed 2 months ago

tomkricensky commented 3 months ago

Android 15 adds support for 16kB page size instead of 4kB.

Because of that all native libraries need to be recompiled with special flags and libraries need to publish a new version with the recompiled native code.

https://developer.android.com/about/versions/15/behavior-changes-all#16-kb

https://developer.android.com/guide/practices/page-sizes

Tested on Android emulator with 16kB page size and with the alignment check script from the documentation.

./libargon2native.so: ALIGNED (2**14)
./libargon2jni.so: ALIGNED (2**14)
lambdapioneer commented 3 months ago

Hi @tomkricensky,

thanks a lot for helpful PR--and the careful testing!

I am currently traveling and will merge/release when I am back begin of September. If you have a dependency on this sooner, let me know and I'll find time.

Cheers, Daniel

tomkricensky commented 3 months ago

Hello,

beginning of September sounds good. Android 15 is not released yet so we still have time.

Thanks for your work on the library.

lambdapioneer commented 2 months ago

Looks good :) in the long-run we probably want to upgrade to NDK 27+ to get it all automagically

tomkricensky commented 2 months ago

To be fair I never really worked with NDK. I just followed the steps from the documentation and made minimal changes to the project.