search

lambdaworks / zio-elasticsearch

ZIO Elasticsearch is a type-safe and streaming-friendly ZIO native Elasticsearch client.
https://lambdaworks.github.io/zio-elasticsearch/
Apache License 2.0
60 stars 18 forks source link

(dsl): Support `geoShape` query #267

Closed bojanbla closed 1 year ago

bojanbla commented 1 year ago

Part of #91

Implement part of the geo_shape query.

Currently supported geo_shapes:

This support only the creation of an inline geo_shape query. Pre-Indexed Shape is not yet supported.

drmarjanovic commented 1 year ago

@bojanbla, are you still working on this? What's missing here?

arnoldlacko commented 1 year ago

@drmarjanovic We've had a discussion some time ago with @bojanbla about this. I believe this will need to be a more complex change than it first seemed, which will require us to stop using the default json codec (defined by zio-schema) when dealing with user defined schemas and write our own (specific to elasticsearch) codec, which will recognise whether some values in the user types are library types (like shapes) and apply a special codec for them defined by the library. If @bojanbla agrees, I think we should archive this PR for now until someone decides to tackle this additional complexity.

bojanbla commented 1 year ago

@arnoldlacko @drmarjanovic Yes, I completely agree. I didn't have enough time to finish it as I wanted. It's fine to close it now. Cause it's more complex than we expected I guess it will be fine to create a separate task to support custom codecs and then support those queries that require it. I think that this one is not the only one that will require that support.