lambeboluwatife / lbdflix

A movie app to see latest movies, movie details, and watch movies trailers.
https://lbdflix.vercel.app
MIT License
11 stars 13 forks source link

Review Accordion #62

Closed kmahesh18 closed 3 weeks ago

kmahesh18 commented 3 weeks ago

Reviews page got setup finely and Changed the layout of reviews too

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lbdflix-haj8 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 11:55am
gitguardian[bot] commented 3 weeks ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/workspace/373204/incidents/secrets) | - | Generic High Entropy Secret | f3bee4e2ea6496d8ca2db66a5ad6049698787b59 | .env | [View secret](https://github.com/lambeboluwatife/lbdflix/commit/f3bee4e2ea6496d8ca2db66a5ad6049698787b59#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dR1) | | [-](https://dashboard.gitguardian.com/workspace/373204/incidents/secrets) | - | Generic High Entropy Secret | 9ef8eae5e65e3cf3821a04c37cab5384662d23c6 | .env | [View secret](https://github.com/lambeboluwatife/lbdflix/commit/9ef8eae5e65e3cf3821a04c37cab5384662d23c6#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dL1) | | [11011289](https://dashboard.gitguardian.com/workspace/373204/incidents/11011289) | Triggered | Generic High Entropy Secret | f3bee4e2ea6496d8ca2db66a5ad6049698787b59 | .env | [View secret](https://github.com/lambeboluwatife/lbdflix/commit/f3bee4e2ea6496d8ca2db66a5ad6049698787b59#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dL1) | | [11011289](https://dashboard.gitguardian.com/workspace/373204/incidents/11011289) | Triggered | Generic High Entropy Secret | 9ef8eae5e65e3cf3821a04c37cab5384662d23c6 | .env | [View secret](https://github.com/lambeboluwatife/lbdflix/commit/9ef8eae5e65e3cf3821a04c37cab5384662d23c6#diff-e9cbb0224c4a3d23a6019ba557e0cd568c1ad5e1582ff1e335fb7d99b7a1055dR1) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

kmahesh18 commented 3 weeks ago

heyy @lambeboluwatife ..can you please check what secrets are revealed... I've solved the issue mentioned exactly and even enhanced the review system

lambeboluwatife commented 3 weeks ago

@kmahesh18 you did an amazing job. I really love it. As for the secrets, it just the API_KEYS that are being pushed to the codebase. Don't worry about that, I'll fix it.

And again, you did great 😃

kmahesh18 commented 3 weeks ago

@kmahesh18 you did an amazing job. I really love it. As for the secrets, it just the API_KEYS that are being pushed to the codebase. Don't worry about that, I'll fix it.

And again, you did great 😃

ThankYou...I'm Just developing my skills participating in hacktober fest ... and i want to know when this pr gets merged so as i can complete and recieve badge in fest...

lambeboluwatife commented 3 weeks ago

Yeah, it has been merged. I love that you used page.modules.css for the styling. I'll say you are the first person I'll come across that use that.