lambjames18 / EBSD-Correction

2 stars 0 forks source link

Inefficiency of applying the correction during saving a new h5 #3

Open lambjames18 opened 2 years ago

lambjames18 commented 2 years ago

As of now, the algorithm creates a new set of solutions for each EBSD data modality. This is incredibly inefficient, and needs to be changed.

I'm sure theres more, but the jist here is that core.py is inefficent and that makes the UI inefficient. Things are tangled and need to be made modular.

lambjames18 commented 1 year ago

Steps to fix:

Note: the reason we need to enforce output.shape == distorted.shape is because Dream3D doesn't allow us to change the shape of the data containers without creating a while new data file (and even that is not supported in python currently).