search

lambrohan / nestjs-meilisearch

Meilisearch module for nestjs applications.
https://www.npmjs.com/package/nestjs-meilisearch
MIT License
22 stars 7 forks source link

Add `meilisearch` as peer dependency #2

Closed thomasdom closed 2 years ago

thomasdom commented 2 years ago

Currently, the module uses meilisearch as a dependency, and at version 0.20.1.

Each meilisearch's version is tied to a specific server version. Using a client version incompatible with server version will cause incompatibilities and may lead to unrecoverable application errors.

The module's user should be able to use any meilisearch version to match with its server implementation.

I also suggest to add meilisearch as dev dependency for module development.

lambrohan commented 2 years ago

@thomasdom That is a great suggestion. I'll update the repo soon. Meanwhile please submit a PR if you like.

thomasdom commented 2 years ago

@lambrohan Ok, I'll try!

thomasdom commented 2 years ago

@lambrohan I've made a PR. Please feel free to review and help me to make better changes if needed, as I'm junior in NestJS library development. Thank you by advance!

lambrohan commented 2 years ago

@thomasdom Awesome