search

lambtron / emojipacks

CLI to bulk upload emojis to your Slack
https://emojipacks.com
MIT License
1.32k stars 198 forks source link

created an all emoji file #118

Closed jenniferabowd closed 7 years ago

jenniferabowd commented 7 years ago

I created a file with all the emojis offered by Emojipack.

zachfeldman commented 7 years ago

Woah, going for it! I like it. Did you test it with a Slack instance with no errors? If so, I will merge.

jenniferabowd commented 7 years ago

Hi Zach,

Yes I tested it and did not get any errors. It takes a half hour to run. Thank you for creating this great project!

Best,

Jennifer Kaplan

On Jun 13, 2017, at 10:30 PM, Zach Feldman notifications@github.com wrote:

Woah, going for it! I like it. Did you test it with a Slack instance with no errors? If so, I will merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lambtron/emojipacks/pull/118#issuecomment-308302091, or mute the thread https://github.com/notifications/unsubscribe-auth/AWBNPUxWCQEWJYiFYy_UawnpMA3sitMCks5sD0XSgaJpZM4N5PvB.

zachfeldman commented 7 years ago

You may thank the mighty @lambtron I am but a humble maintainer. Haha. Consider yourself merged

zachfeldman commented 7 years ago

@jenkaplan sorry but I had to revert your commit because it broke the build :(

https://travis-ci.org/lambtron/emojipacks/builds/242672946?utm_source=email&utm_medium=notification

I still think it's a good idea to do this, however, it might make a little more sense to implement code that joins multiple emoji files so people can make their own multipacks, vs pushing a big multipack with all the emojipacks that exist already, which we'd probably have to update. Maybe something that adds a flag to the emojipacks command to include multiple packs (I don't think you can do this already).

Thanks for your contribution either way!

jenniferabowd commented 7 years ago

Hi Zach,

I’m so sorry it broke the build! This was my first attempt at contributing to open source. Thank you for being so kind and making suggestions.

Best,

Jen

On Jun 14, 2017, at 11:32 AM, Zach Feldman notifications@github.com wrote:

@jenkaplan https://github.com/jenkaplan sorry but I had to revert your commit because it broke the build :(

https://travis-ci.org/lambtron/emojipacks/builds/242672946?utm_source=email&utm_medium=notification https://travis-ci.org/lambtron/emojipacks/builds/242672946?utm_source=email&utm_medium=notification I still think it's a good idea to do this, however, it might make a little more sense to implement code that joins multiple emoji files so people can make their own multipacks, vs pushing a big multipack with all the emojipacks that exist already, which we'd probably have to update. Maybe something that adds a flag to the emojipacks command to include multiple packs (I don't think you can do this already).

Thanks for your contribution either way!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lambtron/emojipacks/pull/118#issuecomment-308469127, or mute the thread https://github.com/notifications/unsubscribe-auth/AWBNPe0dgCq7IeCz7dCEllRuQTIbtUHAks5sD_0JgaJpZM4N5PvB.

zachfeldman commented 7 years ago

No problem!

lambtron commented 7 years ago

This is literally everything.

Thank you @jenkaplan!!

jenniferabowd commented 7 years ago

@lambtron No problem! I'm sorry that this broke your npm build!