search

lambtron / emojipacks

CLI to bulk upload emojis to your Slack
https://emojipacks.com
MIT License
1.32k stars 199 forks source link

CLI does not allow easily path interpretation #129

Open niftylettuce opened 7 years ago

niftylettuce commented 7 years ago

After installing the package globally, it is not easy to get the paths of the files (it's undocumented in the Readme). To the average user it is probably non-trivial to how to do get the full path to the yaml files installed in the directory where emojipacks is.

We should probably check file path passed to see if it's in packs folder.

For example:

Path or URL of Emoji yaml file: animals.yaml
Does the path to the yaml file look right? :)

It should allow animals.yaml, and just animals itself.

niftylettuce commented 7 years ago

I'll be submitting a PR that resolves this.

niftylettuce commented 7 years ago

Nevermind, the codebase is a mess, there's generators defined that don't even have yields. If anyone else wants to do this go ahead.

zachfeldman commented 7 years ago

@niftylettuce thanks for bringing this up!

I'll leave this issue open for a while to see if anyone is interested in helping out besides yourself.

I've traditionally just given the full URL of an emojipack raw from GitHub which works well for me, but I'm just one user....