lamby / django-slack

Slack integration for Django, using the templating engine to generate messages
https://django-slack.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
241 stars 57 forks source link

unfurl_links and unfurl_media aren't passed to Slack endpoint #107

Closed Taskle closed 3 years ago

Taskle commented 3 years ago

Hi there!

Our company has built a bot that posts to a channel with a link on our website in each post (using slack_message - https://github.com/lamby/django-slack/blob/master/django_slack/api.py#L11 ). Given volume, we want to avoid unfurling links every time (so it doesn't feel spammy to the user to keep seeing the link snippets). After a bunch of research and trial-and-error, and testing at https://api.slack.com/methods/chat.postMessage/test we identified that the "unfurl_links" (and "unfurl_media") parameters need to be set to false to handle this properly.

We're able to verify that these parameters fixes our issue using https://api.slack.com/methods/chat.postMessage/test, but these two parameters aren't included in the PARAMS list in slack_message - https://github.com/lamby/django-slack/blob/master/django_slack/api.py#L11 so they never get to the Slack endpoint.

Would love if these could be added to support this functionality!

Taskle commented 3 years ago

@lamby Thanks for merging my commit in! Question: it looks like running "pip install django-slack==5.17.5" is showing an error; only 15.6.2 is installable via pip. Is it possible to package it such that 5.17.5 would be accessible via pip?

ERROR: Could not find a version that satisfies the requirement django-slack==5.17.5 (from versions: 5.17.0.linux-x86_64, 5.17.2.linux-x86_64, 5.17.5.linux-x86_64, 0.0.1, 2, 3, 4, 4.0.1, 4.1.0, 4.1.1, 4.2.0, 4.2.1, 4.2.2, 4.2.3, 4.2.4, 4.2.5, 4.3.0, 4.4.0, 4.4.1, 4.4.2, 4.5.0, 5.0.0, 5.0.1, 5.0.2, 5.0.3, 5.1.0, 5.2.0, 5.2.1, 5.2.2, 5.2.3, 5.3.0, 5.4.0, 5.5.0, 5.5.1, 5.6.0, 5.7.0, 5.7.1, 5.7.2, 5.7.3, 5.8.0, 5.8.1, 5.9.0, 5.10.0, 5.10.1, 5.10.2, 5.11.1, 5.12.0, 5.12.1, 5.13.0, 5.14.0, 5.14.1, 5.14.2, 5.14.3, 5.14.4, 5.15.0, 5.15.2, 5.15.3, 5.16.0, 5.16.1, 5.16.2)

My guess is that this is related to https://pypi.org/project/django-slack/5.17.5/#files showing different files from https://pypi.org/project/django-slack/5.16.2/#files and below.

lamby commented 3 years ago

Is that any better with 5.17.6? I had some hiccups with twine upload not supporting wheel uploads (anymore?)...

Taskle commented 3 years ago

Yes, thank you!!