lamchenghou / pe

0 stars 0 forks source link

Cannot search for past appointments before the current date, which is a very common appointment scheduling feature (e.g. Apple Calendar) #10

Open lamchenghou opened 10 months ago

lamchenghou commented 10 months ago

Command to reproduce: find appt/2023-02-31 image.png

image.png

nus-pe-bot commented 10 months ago

Team's Response

Duplicate of #4612. Not in scope as by design, we have it like this.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

App does not allow users to add appointment dates in the past

The app does not allow users to add appointment dates in the past. However, it might be valuable to allow for past appointment dates for record keeping purposes.


[original: nus-cs2103-AY2324S1/pe-interim#3666] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the report! It is by design that we do not allow APPOINTMENT_DATE to store date past the current date as it is used to indicate future appointments that Financial Advisors (FA) have with the clients instead of showing the latest appointments that the client had with the FA. We felt like it is more important that the app stores future appointments date instead of cluttering them for record keeping purposes. Nonetheless, we will take this into consideration for future implementation as we planned to allow storing multiple APPOINTMENT_DATE (may include past appointments as well) under the same client as indicated in Appendix G in our DG.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** > I strongly believe that this is a `FeatureFlaw` as being able to add/search past appointments is a very commonly used feature. It is limiting one of the main use cases of the app (appointments), and only a small amount of effort is > needed to allow searching clients based on past appointments. \ > ![image.png](https://raw.githubusercontent.com/lamchenghou/pe/main/files/2ca5be37-f95e-468d-9fa0-c27eb002663a.png) > Here are some cases a complete find-by-appointment feature will be useful: > - When an FA falls sick and miss a day of appointments, he/she needs to be able to search for appointment missed at a later date, to reschedule > - If an FA schedules and conducts an appointment with a client, forgetting to note in FAPro, he/she should be able to come back on a later date to note down the appointment \ > \ > **The above missing add/find past appointments will cause great inconvenience, potentially driving users to more suited alternatives such as Apple Calendar.** > This also goes against their value proposition that FAPro will allow users to 'track interactions' (such as appts.) \ > ![image.png](https://raw.githubusercontent.com/lamchenghou/pe/main/files/fd82aa49-a55c-42fc-af99-d142ff5294d5.png) > Further, this cannot be marked `NotInScope` as users will reasonably try to use this feature e.g. to look at which clients they've interacted with before: \ > UG did not specify this as a planned enhancement \ >![image.png](https://raw.githubusercontent.com/lamchenghou/pe/main/files/322ee8dd-ab04-4d84-9270-505df0aad419.png)