search

lamho86 / phylolm

GNU General Public License v2.0
30 stars 12 forks source link

Change bootstrap implementation to future. #14

Closed Ax3man closed 6 years ago

Ax3man commented 6 years ago

I've made the change as suggested by @HenrikBengtsson in #11. A benefit of using future is that the package will now be immediately compatible with many back-ends, including clusters etc. without us doing anything or having to add more functionality later. Here is a talk by Henrik about future.

It also means that it is easy for the user to still get parallel options even when using phylolm indirectly through other depending packages (such as phylopath and perhaps sensiPhy).

Hope this is all clear. Can you let me know when you expect things to be pushed to CRAN?

cecileane commented 6 years ago

This is wonderful. thank you @Ax3man (and @HenrikBengtsson for the suggestion).

lamho86 commented 6 years ago

Hi Wouter,

The new version has been published on CRAN today.

Best, Lam

Lam Ho | Assistant Professor FACULTY OF SCIENCE Department of Mathematics and Statistics 902.494.1069

Dalhousie University dal.ca

On May 23, 2018, at 11:24 AM, Wouter van der Bijl notifications@github.com wrote:

I've made the change as suggested by @HenrikBengtsson https://github.com/HenrikBengtsson in #11 https://github.com/lamho86/phylolm/pull/11. A benefit of using future is that the package will now be immediately compatible with many back-ends, including clusters etc. without us doing anything or having to add more functionality later. Here https://www.youtube.com/watch?v=doa7avxbptQ is a talk by Henrik about future.

It also means that it is easy for the user to still get parallel options even when using phylolm indirectly through other depending packages (such as phylopath and perhaps sensiPhy).

Hope this is all clear. Can you let me know when you expect things to be pushed to CRAN?

You can view, comment on, or merge this pull request online at:

https://github.com/lamho86/phylolm/pull/14 https://github.com/lamho86/phylolm/pull/14 Commit Summary

Change bootstrap implementation to future. File Changes

M DESCRIPTION https://github.com/lamho86/phylolm/pull/14/files#diff-0 (2) M R/phyloglm.R https://github.com/lamho86/phylolm/pull/14/files#diff-1 (18) M R/phylolm.R https://github.com/lamho86/phylolm/pull/14/files#diff-2 (18) M man/phyloglm.Rd https://github.com/lamho86/phylolm/pull/14/files#diff-3 (10) M man/phylolm.Rd https://github.com/lamho86/phylolm/pull/14/files#diff-4 (8) Patch Links:

https://github.com/lamho86/phylolm/pull/14.patch https://github.com/lamho86/phylolm/pull/14.patch https://github.com/lamho86/phylolm/pull/14.diff https://github.com/lamho86/phylolm/pull/14.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lamho86/phylolm/pull/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AG2zv985kEDhBKQ4Lj83NMA_X4I68oFvks5t1XEJgaJpZM4UKjnH.