search

lamho86 / phylolm

GNU General Public License v2.0
30 stars 12 forks source link

phyloglmstep #31

Closed rvosa closed 3 years ago

rvosa commented 4 years ago

I am half and half under the impression that it would be a valid and useful thing to do basically what phylostep does, but then for phyloglm's. I was therefore a bit surprised that this doesn't exist in your package. Am I missing an important reason why one couldn't do this?

If it's simply a matter that you haven't got to because it is not important for your research then I'd be happy to donate an implementation: https://github.com/naturalis/phyloglmstep/blob/master/R/phyloglmstep.R

It is literally the exact same code as phylostep except you have to pass in the arguments for phyloglm instead, and phyloglm instead of phylolm is invoked in the function body. It seems to me you can do the same AIC-based nested model comparisons so I kept that all the same.

cecileane commented 4 years ago

I agree! The reason is indeed a total lack of time (on my end) and the need to prioritize other projects --projects that will help students graduate, for instance.

lamho86 commented 4 years ago

@rvosa: This should be useful. Could you create a pull request?