lamikr / rocm_sdk_builder

Other
132 stars 12 forks source link

rocm_smi_lib gcc 14 build fix #19

Closed lamikr closed 4 months ago

lamikr commented 4 months ago

fix the modify of readonly object detected by gcc_14

[ 24%] Building CXX object oam/CMakeFiles/oam.dir/__/src/rocm_smi_utils.cc.o In file included from /home/lamikr/own/rocm/src/sdk/rocm_sdk_builder_611/src_projects/rocm_smi_lib/src/rocm_smi_power_mon.cc:52: /home/lamikr/own/rocm/src/sdk/rocm_sdk_builder_611/src_projects/rocm_smi_lib/include/rocm_smi/rocm_smi_utils.h: In member function ‘amd::smi::ScopeGuard& amd::smi::ScopeGuard::operator=(const amd::smi::ScopeGuard&)’: /home/lamikr/own/rocm/src/sdk/rocm_sdk_builder_611/src_projects/rocm_smi_lib/include/rocm_smi/rocm_smiutils.h:237:18: error: assignment of member ‘dismiss’ in read-only object 237 | rhs.dismiss_ = true;

Thank you for Crizle for bug report and link for the fix patch.

lamikr commented 4 months ago

Tested that rocm_smi_lib builds ok also on Mageia 9 with patch applied and without causing new problems.