lamikr / rocm_sdk_builder

Other
113 stars 8 forks source link

Order of commands in the readme could be a bit better #4

Open flip111 opened 1 month ago

flip111 commented 1 month ago

At the moment it's

./install_deps.sh
git config --global user.name "John Doe"
git config --global user.email johndoe@example.com
source /opt/rock_sdk_<version>/bin/env_rocm.sh
git clone https://github.com/lamikr/rocm_sdk_builder.git
cd rocm_sdk_builder
git checkout releases/rocm_sdk_builder_611
./babs.sh -i
./babs.sh -b

when reading from top to bottom and following instructions as you go, then this order makes a bit more sense:

git clone https://github.com/lamikr/rocm_sdk_builder.git
cd rocm_sdk_builder
git checkout releases/rocm_sdk_builder_611
./install_deps.sh
git config --global user.name "John Doe"
git config --global user.email johndoe@example.com
./babs.sh -i
./babs.sh -b
source /opt/rock_sdk_<version>/bin/env_rocm.sh

perhaps the surrounding text can be re-ordered to match the logical commands