search

lamikr / rocm_sdk_builder

Other
132 stars 12 forks source link

Nice to have: checking git global variable #6

Open flip111 opened 4 months ago

flip111 commented 4 months ago

It would be good if ./babs.sh -i refused to run when user.name and user.email is not set globally. Also it would probably be good to abort the script as soon as one of the patches fail to apply.

lamikr commented 4 months ago

I did some modifications to apply patch command. Are you able to check whether it's now cleaner?

./babs.sh -co
./babs.so -ap

I am kind of wondering should I have just have made one command to perform both actions. Or add third command which compines these. Any opinions?

flip111 commented 3 months ago

I would combine the commands the commands that are necessary to start the build. And then any further commands to do the build. As those two actions take the most amount of time. Any other commands i would leave it up to the user to call them after each other for more fine grained control.