Update 0009-fedora40-build-breaks-for-uninitialized-variables.patch

lamikr / rocm_sdk_builder

Other

113 stars 8 forks source link

Update 0009-fedora40-build-breaks-for-uninitialized-variables.patch #72

Closed jeroen-mostert closed 1 week ago

jeroen-mostert commented 1 week ago

The patch works, but it removes one of the tests outright. These changes remove the warnings by pushing the initializations to the declarations without actually changing what the code does.

lamikr commented 1 week ago

Yes, your change looks good. I will however test rebuild it just in case. You could propably to send your version of patch to the onnxruntime also as a pull request?

jeroen-mostert commented 1 week ago

Eh, I'm good with just getting this repo to build. A proper pull for gcc 14.1.1 (which seems to be the common factor in new warnings popping up) also needs to fix the other issues we're now separately patching (aside from the ROCm-specific stuff). I'm uncomfortably spread across two machines at the moment, neither of which are properly set up for doing Git work. If more work pops up I'll buckle down and stop being lazy.

lamikr commented 1 week ago

Thanks for the PR, it's now on master and 612 branches.