search

lamikr / rocm_sdk_builder

Other
113 stars 8 forks source link

Fix segfault in amd-fftw by removing dynamic dispatcher #83

Closed jeroen-mostert closed 5 days ago

jeroen-mostert commented 6 days ago

Removes the --enable-dynamic-dispatcher flag that results in a library that segfaults on dlopen() on at least some versions of Ubuntu and Manjaro. Fixes #74.

Note: this also fixes some typos in the flags (--enable-sse2, and --enable-double is not a thing as it's the default) and removes two export commands which were only present in the build for single precision, the purpose of which is unclear to me. It didn't seem to do anything when I built things, and in any case it makes no sense to have it only there.

This should be considered a stopgap until we figure out the actual impact (in terms of performance/functionality) of removing this flag, if any, but that's covered in #82.

lamikr commented 5 days ago

Thanks for the patch. The exports in one binfo file were lefteovers from some test. Good that they are now also cleaned.