laminas-api-tools / api-tools-doctrine

Laminas API Tools Doctrine module
https://api-tools.getlaminas.org/documentation
BSD 3-Clause "New" or "Revised" License
10 stars 21 forks source link

Builds failing with composer plugin error #32

Closed javabudd closed 4 months ago

javabudd commented 2 years ago

Bug Report

| Version(s) | 2.5.x

Summary

Builds against the 2.5.x branch (and possibly others) are failing due to a composer 2 security setting regarding allowable plugins. Example of a failed build that had no code changes and still failed. This could be happening on many Laminas libraries as it seems like it stems from laminas-ci-matrix-action.

Current behavior

All Github Actions builds are failing on the 2.5.x branch.

How to reproduce

Create a pull request into the 2.5.x branch to trigger a build.

Expected behavior

Builds should pass assuming no code changes have been made.

Ocramius commented 2 years ago

Seems to just be an issue with very old composer.json, while composer/composer:^2.3 onwards broke BC by introducing required config for any plugins to be run.

This section needs adjustment:

https://github.com/laminas-api-tools/api-tools-doctrine/blob/675e8eed316b2d35d76688ed1ed1ba8bda8f1fea/composer.json#L20-L22

Here's an example of how plugins are configured in laminas/laminas-servicemanager:

https://github.com/laminas/laminas-servicemanager/blob/166c5687ac2f48790fed854387327da28afbf088/composer.json#L23-L33

javabudd commented 2 years ago

Good find, I'll submit a PR to fix.

javabudd commented 1 year ago

new PR that addresses the issue:

https://github.com/laminas-api-tools/api-tools-doctrine/pull/35