laminas-api-tools / api-tools-doctrine

Laminas API Tools Doctrine module
https://api-tools.getlaminas.org/documentation
BSD 3-Clause "New" or "Revised" License
10 stars 21 forks source link

Replace phpro/zf-doctrine-hydration-module with doctrine/doctrine-laminas-hydrator #34

Closed javabudd closed 4 months ago

javabudd commented 2 years ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC yes
QA no

Description

javabudd commented 2 years ago

This PR branches off https://github.com/laminas-api-tools/api-tools-doctrine/pull/33 to attempt to fix CI builds for PHP 8

javabudd commented 2 years ago

Declining in favor of https://github.com/laminas-api-tools/api-tools-doctrine/pull/29

javabudd commented 1 year ago

Reopening this PR as #29 has become stale and other PR's to address this issue are using incorrect hydrator libraries.

ajgale commented 1 year ago

+1 on this as it is still preventing much needed PHP 8 upgrade

speby commented 1 year ago

Also +1 on this

datasage commented 1 year ago

Please push this through. Will help get the rest of the project up to PHP 8.1/8.2

davidwindell commented 1 year ago

Is this likely to get merged anytime soon @Ocramius @weierophinney? We are starting a new API Tools project and would be good to have some direction. Thank you!

davidwindell commented 1 year ago

@javabudd I see you are still targeting PHP 8.0 (not 8.1). I guess this repo is abandoned now, so we'll roll our own Doctrine integration.

TomHAnderson commented 1 year ago

I was the original author of this repository. And I'm a principal on doctrine-laminas-hydrator. Since I left this project I've seen very little movement on this repository. That is unfortunate.

I've moved on to GraphQL now. @davidwindell if you're starting a new project I would encourage you to consider GraphQL. My integration library is here: https://github.com/API-Skeletons/doctrine-orm-graphql

davidwindell commented 1 year ago

Thanks for the ping @TomHAnderson. REST makes more sense for our use case but will certainly bear doctrine-orm-graphql in mind for future projects :+1:

javabudd commented 1 year ago

I was the original author of this repository. And I'm a principal on doctrine-laminas-hydrator. Since I left this project I've seen very little movement on this repository. That is unfortunate.

I've moved on to GraphQL now. @davidwindell if you're starting a new project I would encourage you to consider GraphQL. My integration library is here: https://github.com/API-Skeletons/doctrine-orm-graphql

I would be more than happy to assist with this repository, hence the pull request, but it seems nobody is willing to review or merge PR's anymore.

Ocramius commented 1 year ago

FWIW:

We're spread very thin over here, heh.

datasage commented 1 year ago

I've been maintaining my own branches for forward compatibility. I can help with the effort needed to ensure that this repo is compatible with 8.2 and 8.3

davidwindell commented 1 year ago

We're spread very thin over here, heh.

@Ocramius thank you for these meeting minutes. I am shocked to read the "laminas-mvc seems to be almost dead" comment. I guess I need to catch up with the times and start looking at Mezzio.

davidwindell commented 1 year ago

FYI we ended up going with API Platform.