laminas-api-tools / api-tools-mvc-auth

Laminas Module providing Authentication and Authorization events and infrastructure
https://api-tools.getlaminas.org/documentation
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

[WIP] Composite auth adapter #17

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

As originally proposed in #65

This PR adds the possibility to use multiple authentication adapters under the same type.

It also introduces an AdapterAbstractFactory that allows to retrieve each adapter from the ServiceManager under the naming convention zf-mvc-auth-authentication-adapters-{type}. This enables a new method to register custom adapters: using a service name the adapter key of a named adapter configuration.

TO-DO:


Originally posted by @stefanotorresi at https://github.com/zfcampus/zf-mvc-auth/pull/76

weierophinney commented 4 years ago

@stefanotorresi This looks fantastic! Any chance you can wrap up the lingering todo items soonish?


Originally posted by @weierophinney at https://github.com/zfcampus/zf-mvc-auth/pull/76#issuecomment-117338123

weierophinney commented 4 years ago

@weierophinney been a bit busy lately, but I'll try to attend to this before the end of this week!


Originally posted by @stefanotorresi at https://github.com/zfcampus/zf-mvc-auth/pull/76#issuecomment-117553458

weierophinney commented 4 years ago

@stefanotorresi I pulled this locally, rebased it off of current develop, and tried to push to your branch... but could not. So I did a PR for you: stefanotorresi/zf-mvc-auth#1

The tasks you have listed above are still incomplete, and, honestly, I'm unsure how to complete the first 2. If you would like to continue with this patch, please merge the PR I sent you, and push changes back to your branch when complete.

Thanks!


Originally posted by @weierophinney at https://github.com/zfcampus/zf-mvc-auth/pull/76#issuecomment-386049236