laminas-api-tools / api-tools-oauth2

Laminas module for implementing an OAuth2 server
https://api-tools.getlaminas.org/documentation
BSD 3-Clause "New" or "Revised" License
11 stars 15 forks source link

remove NOT NULL for client_secret #9

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

In oauth_clients -> client_secret character varying(80) NOT NULL,

And then in PDO: public function isPublicClient($client_id) { $stmt = $this->db->prepare(sprintf('SELECT * from %s where client_id = :client_id', $this->config['client_table'])); $stmt->execute(compact('client_id')); if (!$result = $stmt->fetch(\PDO::FETCH_ASSOC)) { return false; } return empty($result['client_secret']); }

How can $result['client_secret'] be empty? IMHO the "NOT NULL" is wrong as it is needed I.E. for 'allow_implicit' => true example.


Originally posted by @goalain at https://github.com/zfcampus/zf-oauth2/issues/156